- 
                Notifications
    
You must be signed in to change notification settings  - Fork 31
 
feat: Only partially functional preview removed, CSS and JS refactor #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   89.01%   89.13%   +0.12%     
==========================================
  Files         124      124              
  Lines        3386     3387       +1     
  Branches      288      288              
==========================================
+ Hits         3014     3019       +5     
+ Misses        254      252       -2     
+ Partials      118      116       -2     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
| 
           @sourcery-ai review  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later
| 
           @SourceryAI review  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later
| 
           @SourceryAI review  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later
| 
           @SourceryAI when does the rate limit expire  | 
    
| 
           The rate limit for Sourcery review comments is typically imposed to prevent excessive requests and potential spam. The exact duration can vary depending on GitHub and Sourcery's own policies, but most rate limits reset after a short period—often within an hour. If you've hit a rate limit, it's best to wait a bit and then try again. If you continue to experience issues, please let me know and I can help investigate further!  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the webpack-bundled JavaScript files and simplifies the build process by eliminating npm dependencies and switching to plain JavaScript. The main changes include:
- Removal of webpack bundles and transition to dependency-free plain JavaScript
 - Bootstrap CSS dependency removal with custom UI styling now fully integrated in the 
/private/sassfolder - CSS updates for compatibility with upcoming UI design changes
 - Removal of the preview functionality for links/buttons due to misleading previews
 
Reviewed Changes
Copilot reviewed 53 out of 58 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description | 
|---|---|
| tools/tasks/*.js | Removed webpack, svg, and lint gulp tasks | 
| private/js/*.js | Removed webpack configuration and all component JS files | 
| djangocms_frontend/static//js/bundle..js | Removed webpack-generated bundle files | 
| djangocms_frontend/static/*/js/grid.js | New plain JavaScript implementation replacing webpack bundle | 
| private/sass/components/*.scss | Updated SCSS with new variables, button styles, and removed preview styles | 
| djangocms_frontend/templates//admin/.html | Updated script references from bundles to plain JS files | 
| package.json | Significantly reduced dependencies, removing webpack and related packages | 
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| 
               | 
          ||
| .errorlist { | ||
| @include visually-hidden; | ||
| // @include visually-hidden; | 
    
      
    
      Copilot
AI
    
    
    
      Aug 15, 2025 
    
  
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented out @include visually-hidden; line should either be removed if it's no longer needed or properly implemented if it serves a purpose. Commented code can lead to confusion about intended behavior.
| // @include visually-hidden; | 
This PR fixes the issue #299 by removing the bundled JS files and simplifying the CSS build process
/private/sassfolder.The link/button's preview has been removed, since it regularly shows misleading previews due to the different styling of django admin and the site itself.