Skip to content

Conversation

@fsbraun
Copy link
Member

@fsbraun fsbraun commented Aug 14, 2025

This PR fixes the issue #299 by removing the bundled JS files and simplifying the CSS build process

  1. Webpack bundles are removed, and the little JS logic needed for the UI is now dependency-free, plain Javascript (no jQuery). No more npm-induced dependencies.
  2. Bootstrap CSS dependency has been removed. The UI element styling - especially the tabs when editing a plugin - are now fully integrated in the /private/sass folder.
  3. CSS has been updated for compatibility with the upcoming UI design

The link/button's preview has been removed, since it regularly shows misleading previews due to the different styling of django admin and the site itself.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later

@fsbraun fsbraun changed the title chore: CSS and JS refactor feat: Only partially functional preview removed, CSS and JS refactor Aug 14, 2025
@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.13%. Comparing base (554418c) to head (f1a5532).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   89.01%   89.13%   +0.12%     
==========================================
  Files         124      124              
  Lines        3386     3387       +1     
  Branches      288      288              
==========================================
+ Hits         3014     3019       +5     
+ Misses        254      252       -2     
+ Partials      118      116       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fsbraun
Copy link
Member Author

fsbraun commented Aug 14, 2025

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later

Copy link

@SourceryAI SourceryAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later

@fsbraun
Copy link
Member Author

fsbraun commented Aug 15, 2025

@SourceryAI review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later

@fsbraun
Copy link
Member Author

fsbraun commented Aug 15, 2025

@SourceryAI review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @fsbraun, you have reached your 24-hour rate limit for Sourcery. Please try again later

@fsbraun
Copy link
Member Author

fsbraun commented Aug 15, 2025

@SourceryAI when does the rate limit expire

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 15, 2025

The rate limit for Sourcery review comments is typically imposed to prevent excessive requests and potential spam. The exact duration can vary depending on GitHub and Sourcery's own policies, but most rate limits reset after a short period—often within an hour. If you've hit a rate limit, it's best to wait a bit and then try again. If you continue to experience issues, please let me know and I can help investigate further!

@fsbraun fsbraun requested a review from Copilot August 15, 2025 10:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the webpack-bundled JavaScript files and simplifies the build process by eliminating npm dependencies and switching to plain JavaScript. The main changes include:

  • Removal of webpack bundles and transition to dependency-free plain JavaScript
  • Bootstrap CSS dependency removal with custom UI styling now fully integrated in the /private/sass folder
  • CSS updates for compatibility with upcoming UI design changes
  • Removal of the preview functionality for links/buttons due to misleading previews

Reviewed Changes

Copilot reviewed 53 out of 58 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tools/tasks/*.js Removed webpack, svg, and lint gulp tasks
private/js/*.js Removed webpack configuration and all component JS files
djangocms_frontend/static//js/bundle..js Removed webpack-generated bundle files
djangocms_frontend/static/*/js/grid.js New plain JavaScript implementation replacing webpack bundle
private/sass/components/*.scss Updated SCSS with new variables, button styles, and removed preview styles
djangocms_frontend/templates//admin/.html Updated script references from bundles to plain JS files
package.json Significantly reduced dependencies, removing webpack and related packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.


.errorlist {
@include visually-hidden;
// @include visually-hidden;
Copy link

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented out @include visually-hidden; line should either be removed if it's no longer needed or properly implemented if it serves a purpose. Commented code can lead to confusion about intended behavior.

Suggested change
// @include visually-hidden;

Copilot uses AI. Check for mistakes.
@fsbraun fsbraun merged commit b84bab7 into main Aug 15, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants