Skip to content

Conversation

@fsbraun
Copy link
Member

@fsbraun fsbraun commented Feb 3, 2025

  • Directly add accordion item
  • Directly add columns to rows

Summary by Sourcery

Enable adding accordion items and columns to rows directly in Django CMS 4.2.

New Features:

  • Add accordion items directly.
  • Add columns to rows directly.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 3, 2025

Reviewer's Guide by Sourcery

This pull request enhances the Django CMS integration by directly adding accordion items and columns to rows, leveraging Django CMS 4.2 capabilities. It achieves this by setting show_plugin_add_form to False in the relevant plugins, which allows for direct content addition.

Class diagram showing plugin modifications

classDiagram
    class GridContainerPlugin {
        +show_plugin_add_form: bool
        +allow_children: bool
    }
    class GridColumnPlugin {
        -edit_disabled: bool
        +show_plugin_add_form: bool
    }
    class AccordionItemPlugin {
        +show_plugin_add_form: bool
        +allow_children: bool
    }
    note for GridColumnPlugin "Removed edit_disabled
Added show_plugin_add_form"
    note for GridContainerPlugin "Added show_plugin_add_form"
    note for AccordionItemPlugin "Added show_plugin_add_form"
Loading

File-Level Changes

Change Details Files
Disabled the plugin add form for GridContainerPlugin.
  • Set show_plugin_add_form to False to allow direct content addition to the plugin.
djangocms_frontend/contrib/grid/cms_plugins.py
Disabled the plugin add form for GridColumnPlugin.
  • Set show_plugin_add_form to False to allow direct content addition to the plugin.
djangocms_frontend/contrib/grid/cms_plugins.py
Disabled the plugin add form for AccordionItemPlugin.
  • Set show_plugin_add_form to False to allow direct content addition to the plugin.
djangocms_frontend/contrib/accordion/cms_plugins.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fsbraun - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (18d0795) to head (17d53d0).
Report is 35 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   88.36%   88.37%           
=======================================
  Files         123      123           
  Lines        3233     3235    +2     
  Branches      259      259           
=======================================
+ Hits         2857     2859    +2     
  Misses        266      266           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These looks good to me. I am merging them now.

@vinitkumar vinitkumar merged commit a6ed22d into django-cms:master Feb 24, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants