- 
                Notifications
    
You must be signed in to change notification settings  - Fork 31
 
feat: Use Django CMS 4.2 capabilities #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          
Reviewer's Guide by SourceryThis pull request enhances the Django CMS integration by directly adding accordion items and columns to rows, leveraging Django CMS 4.2 capabilities. It achieves this by setting  Class diagram showing plugin modificationsclassDiagram
    class GridContainerPlugin {
        +show_plugin_add_form: bool
        +allow_children: bool
    }
    class GridColumnPlugin {
        -edit_disabled: bool
        +show_plugin_add_form: bool
    }
    class AccordionItemPlugin {
        +show_plugin_add_form: bool
        +allow_children: bool
    }
    note for GridColumnPlugin "Removed edit_disabled
Added show_plugin_add_form"
    note for GridContainerPlugin "Added show_plugin_add_form"
    note for AccordionItemPlugin "Added show_plugin_add_form"
    File-Level Changes
 Tips and commandsInteracting with Sourcery
 Customizing Your ExperienceAccess your dashboard to: 
 Getting Help
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fsbraun - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
 - 🟢 Security: all looks good
 - 🟢 Testing: all looks good
 - 🟢 Complexity: all looks good
 - 🟢 Documentation: all looks good
 
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   88.36%   88.37%           
=======================================
  Files         123      123           
  Lines        3233     3235    +2     
  Branches      259      259           
=======================================
+ Hits         2857     2859    +2     
  Misses        266      266           
  Partials      110      110           ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These looks good to me. I am merging them now.
Summary by Sourcery
Enable adding accordion items and columns to rows directly in Django CMS 4.2.
New Features: