Skip to content

Conversation

@corentinbettiol
Copy link
Contributor

Fix #38 (more a temporary workaround than a permanent solution).
Svg files are now embedded in backgroung-image css in order to prevent CORS errors.

The info icon is still blue, thanks to the fill property.
image

But the other icons won't turn blue if selected.
image

*svg files are now embedded in backgroung-image css in order to prevent CORS errors
@corentinbettiol
Copy link
Contributor Author

(I don't really know why one test is failing, but I think it's because the test package used is broken)

@codecov-commenter
Copy link

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #108    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           68        68            
  Lines         1286      1465   +179     
  Branches        87       123    +36     
==========================================
+ Hits          1286      1465   +179     
Impacted Files Coverage Δ
...gocms_bootstrap4/contrib/bootstrap4_card/models.py 100.00% <0.00%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_grid/models.py 100.00% <0.00%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_link/models.py 100.00% <0.00%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_tabs/models.py 100.00% <0.00%> (ø)
...ocms_bootstrap4/contrib/bootstrap4_badge/models.py 100.00% <0.00%> (ø)
...cms_bootstrap4/contrib/bootstrap4_alerts/models.py 100.00% <0.00%> (ø)
...ms_bootstrap4/contrib/bootstrap4_content/models.py 100.00% <0.00%> (ø)
...ms_bootstrap4/contrib/bootstrap4_picture/models.py 100.00% <0.00%> (ø)
...s_bootstrap4/contrib/bootstrap4_carousel/models.py 100.00% <0.00%> (ø)
...s_bootstrap4/contrib/bootstrap4_collapse/models.py 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b93b04...ef38e98. Read the comment docs.

@FinalAngel
Copy link
Member

thank you @corentinbettiol

@FinalAngel FinalAngel merged commit a8300c3 into django-cms:master Aug 19, 2020
sgordeychuk pushed a commit that referenced this pull request Nov 6, 2020
*svg files are now embedded in backgroung-image css in order to prevent CORS errors

(cherry picked from commit a8300c3)
@corentinbettiol corentinbettiol deleted the fix-external-svg branch January 27, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem loading svg files from s3

3 participants