feat: never refetch with useDocumentCreatedBy()
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$originalVersionIdToDeviceId maps a versionId to a deviceId. It was a temporary workaround for this information not being included in the docs returned from the server, but it adds RPC round-trip overhead. The result of this query never changes for a given versionId, so it does not need to be refetched and can be cached for ever. Because there are never going to be more than a few hundred deviceIds in a project, I think it's ok to never garbage collect this data, and just keep them cached for ever. This small change should reduce the number of RPC requests when re-visiting the observation list page.
gmaclennan
changed the title
useDocumentCreatedBy()
achou11
approved these changes
Aug 28, 2025
This was referenced Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$originalVersionIdToDeviceId()maps a versionId to a deviceId. It was a temporary workaround for this information not being included in the docs returned from the server, but it adds RPC round-trip overhead. The result of this query never changes for a given versionId, so it does not need to be refetched and can be cached for ever. Because there are never going to be more than a few hundred deviceIds in a project, I think it's ok to never garbage collect this data, and just keep them cached for ever.This small change should reduce the number of RPC requests when re-visiting the observation list page.
This is a short-term fix — the longer-term fix is to return a
createdByfield on docs returned from core, removing the need for theuseDocumentCreatedBy()hook: digidem/comapeo-core#136