This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Push PerCharacterEscaper #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trickybrain <[email protected]>
nedtwigg
reviewed
Mar 7, 2024
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
Great job that the tests are passing! Some style things to cleanup.
added 2 commits
March 7, 2024 11:16
… __first_offset_needing_escape
… __first_offset_needing_escape
nedtwigg
suggested changes
Mar 7, 2024
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
This looks great, one last small change before it gets merged.
nedtwigg
suggested changes
Mar 8, 2024
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
The last commit fixed an issue, but created a new one.
nedtwigg
approved these changes
Mar 8, 2024
Member
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.