This repository was archived by the owner on Apr 4, 2024. It is now read-only.
CommentTracker.py #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedtwigg
reviewed
Mar 5, 2024
Member
nedtwigg
left a comment
nedtwigg
left a comment
There was a problem hiding this comment.
Great! Just a few small changes needed.
Comment on lines
20
to
23
| class FS: | ||
| def fileRead(self, typedPath: "TypedPath") -> str: | ||
| # Placeholder return or raise NotImplementedError | ||
| raise NotImplementedError("fileRead is not implemented") |
Member
There was a problem hiding this comment.
Selfie Kotlin's FS abstraction is for javascript within-browser testing. In Python, we can just read and write files, no FS needed.
Comment on lines
38
to
40
| self.cache: Dict[TypedPath, WritableComment] = defaultdict( | ||
| lambda: WritableComment.NO_COMMENT | ||
| ) |
Member
There was a problem hiding this comment.
- in reference implementation, this was an
ArrayMap. It's fine to use dict instead, that's good and pythonic, but thenTypedPathwill need to implement__hash__ - we don't want a default value, because we use null to determine if we need to do the calculation
Member
|
Excellent! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.