Wrong class in CDI Extensions Check

[stefanorg]

Hi i think that this:

spring-data-dynamodb/src/main/java/org/socialsignin/spring/data/dynamodb/repository/cdi/DynamoDBRepositoryExtension.java

Line 76 in 40bd99e

if (type instanceof Class<?> && AmazonDynamoDBClient.class.isAssignableFrom((Class<?>) type)) {

should be

... && AmazonDynamoDB.class ...

This way in a CDI context i can have a Producer of AmazonDynamoDB:

@Bean @Produces
    public AmazonDynamoDB amazonDynamoDB() {
//        return AmazonDynamoDBClientBuilder
//          .standard()
//          .withCredentials(amazonAWSCredentialsProvider())
//          .withRegion(Regions.EU_WEST_1).build();

        return AmazonDaxClientBuilder
          .standard()
          .withCredentials(amazonAWSCredentialsProvider())
          .withRegion(Regions.EU_WEST_1)
          .withEndpointConfiguration("**********************************")
          .build();


    }

Thanks

[derjust]

Yes, resorting to the interface is all we need - no need to be that 'specific'

Will be part of 5.1.0 (Available as part of 5.1.0-SNAPSHOT as of now)

[stefanorg]

Hi i'm not able to see this fix in 5.1.0 branch.

https://github.com/derjust/spring-data-dynamodb/blob/v5.1.0/src/main/java/org/socialsignin/spring/data/dynamodb/repository/cdi/DynamoDBRepositoryExtension.java

Do you need a pull request for this?
When do you think this can be fixed?

Thank for your work 👍