Skip to content

Conversation

@neilmartin83
Copy link
Contributor

@neilmartin83 neilmartin83 commented Oct 21, 2025

Change

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

CRUD for Smart and Static Computer Groups using the current v2 Pro API endpoints. Functions are named to match the endpoint version for future proofing. Idea being when there's an endpoint version bump, we create new funcs that reference that, alongside these. Then any downstream projects can move over as/when they like without any impact to their current behaviour.

I have tested the example scripts updated here as well, all successful and achieve the expected results for each function.

Creating/updating Static Groups is not useful for the Terraform provider at the moment due to needing computer ID assignments (can't create an empty group). See https://ideas.jamf.com/ideas/JPRO-I-1735

Type of Change

Please DELETE options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)
  • Refactor (refactoring code, removing code, changing code structure)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@neilmartin83 neilmartin83 requested a review from ShocOne as a code owner October 21, 2025 14:27
@neilmartin83 neilmartin83 changed the title feat: add full support for api/v2/computer-groups/smart-groups feat: add full support for api/v2/computer-groups Oct 21, 2025
Copy link
Member

@ShocOne ShocOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ShocOne ShocOne merged commit 177ed34 into deploymenttheory:main Oct 23, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants