added ability to provide a path to a template file #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it occurs to me, I don't know if |
add pylint action
|
kind of forgot that further commits to master would be included in the pull request automatically. |
|
I reverted the extra changes I made, so now it is just the one change in the diff / pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows pystache.render to take a file path string to a template file as the template argument. This should be safe because it would be hard to craft a valid template string that is also a valid path to a real file. (the logic only triggers if the argument is a string that points to a valid readable file)
I did run the pystache tests including the spec ones, all passed.