Skip to content

fix: IrisGridModelUpdater causes "cannot update during an existing state transition" warning #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

fix: IrisGridModelUpdater causes "cannot update during an existing state transition" warning #2536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/iris-grid/src/IrisGridModelUpdater.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,6 @@ function IrisGridModelUpdater({
},
[model, isTotalsAvailable, totalsConfig]
);
useOnChange(
function updateFrozenColumns() {
if (frozenColumns) {
model.updateFrozenColumns(frozenColumns);
}
},
[model, frozenColumns]
);
useOnChange(
function updateColumnHeaderGroups() {
model.columnHeaderGroups = columnHeaderGroups;
Expand All @@ -204,6 +196,14 @@ function IrisGridModelUpdater({
);
// These setters are wrapped in useEffect instead of useOnChange because they emit an event
// that potentially causes side effects, violating the rule that render should be a pure function.
useEffect(
function updateFrozenColumns() {
if (frozenColumns) {
model.updateFrozenColumns(frozenColumns);
}
},
[model, frozenColumns]
);
useEffect(
function updatePendingRowCount() {
model.pendingRowCount = pendingRowCount;
Expand Down
Loading