Skip to content

Conversation

ericlln
Copy link
Contributor

@ericlln ericlln commented Sep 17, 2025

IrisGridModelUpdater displays an error/warning in the browser console when

  • The reset button is clicked in the organize columns tab in the sidebar of the grid
  • A rollup is added to the table using the sidebar tab

These warnings were causing two e2e tests to fail locally. Full logs can be found in the ticket.

Similar to #2249, it looks like the frozenColumns setter in IrisGridModelUpdater was also emitting an event in the render cycle that caused a React warning about the render not being a pure function, because the event triggered a state update in IrisGrid. The setter is now wrapped in useEffect instead of useOnChange so the events are emitted after the render.

@ericlln ericlln self-assigned this Sep 17, 2025
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.57%. Comparing base (d1b557f) to head (47b6db1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGridModelUpdater.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2536   +/-   ##
=======================================
  Coverage   44.57%   44.57%           
=======================================
  Files         764      764           
  Lines       42807    42807           
  Branches    10765    10765           
=======================================
  Hits        19083    19083           
  Misses      23713    23713           
  Partials       11       11           
Flag Coverage Δ
unit 44.57% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ericlln ericlln requested review from a team and vbabich and removed request for a team September 17, 2025 14:49
@ericlln ericlln marked this pull request as ready for review September 17, 2025 14:49
@ericlln ericlln merged commit ee2ba42 into deephaven:main Sep 18, 2025
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants