fix: IrisGridModelUpdater causes "cannot update during an existing state transition" warning #2536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IrisGridModelUpdater
displays an error/warning in the browser console whenThese warnings were causing two e2e tests to fail locally. Full logs can be found in the ticket.
Similar to #2249, it looks like the
frozenColumns
setter inIrisGridModelUpdater
was also emitting an event in the render cycle that caused a React warning about the render not being a pure function, because the event triggered a state update inIrisGrid
. The setter is now wrapped inuseEffect
instead ofuseOnChange
so the events are emitted after the render.