Include and extend support #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix includes in build case. Update tests.
|
+1 |
|
Are there any plans to merge this PR? Would love to be able to use require-jade, but lacking include/extend support is a dealbreaker. 😦 |
|
Well you are welcome to use my branch for the time being. I could look into any issues you have. |
Fix includes/extends when using full URL (i.e. http://www.domain.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested both client-side and run-time setups. It seems to work fine for simple testcases. I have not done any excludeJade testing, seems I am unsure whether it works at all even without my changes but my changes should not affect anything else other than the extended syntax support. I am aware that you would like to keep changes to Jade to minimal and my changes are perfectly scriptable if one wanted to make a script to convert jade to require-jade. Enjoy! This should fix issues #10 and #11. Also issue #8 should be fixed.