Expose References via VBA Parser object #839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJLockhart
commented
Feb 9, 2024
|
|
||
| if check == 0x0016: | ||
| # REFERENCENAME | ||
| REFERENCENAME = "REFERENCENAME" |
There was a problem hiding this comment.
Changed the comments to constants because further down I didn't want to duplicate a string. But does have the side effect of changing the log output slightly. Is this OK?
AndrewJLockhart
commented
Feb 9, 2024
| referenceregistered_sizeof_libid = struct.unpack("<L", dir_stream.read(4))[0] | ||
| referenceregistered_libid = dir_stream.read(referenceregistered_sizeof_libid) | ||
| log.debug('REFERENCE registered lib id: %s' % unicode2str(self.decode_bytes(referenceregistered_libid))) | ||
| referenceregistered_libid = unicode2str(self.decode_bytes(dir_stream.read(referenceregistered_sizeof_libid))) |
There was a problem hiding this comment.
Only wanted to call the decode once. Result is used in the log and also sent to the references list
AndrewJLockhart
commented
Feb 9, 2024
| unused = referenceproject_id | ||
| unused = referenceproject_size | ||
| unused = referenceproject_libidabsolute | ||
| unused = referenceproject_libidrelative |
There was a problem hiding this comment.
Actually, I think I need to leave the assignment unused = referenceproject_libidrelative because it isn't being used anywhere else.
AndrewJLockhart
commented
Feb 9, 2024
AndrewJLockhart
changed the title
AndrewJLockhart
commented
Feb 10, 2024
| referencecontrol_sizetwiddled = struct.unpack("<L", dir_stream.read(4))[0] # ignore | ||
| referencecontrol_sizeof_libidtwiddled = struct.unpack("<L", dir_stream.read(4))[0] | ||
| referencecontrol_libidtwiddled = dir_stream.read(referencecontrol_sizeof_libidtwiddled) | ||
| log.debug('REFERENCE control twiddled lib id: %s' % unicode2str(self.decode_bytes(referencecontrol_libidtwiddled))) |
There was a problem hiding this comment.
Still can't find an example of a twiddled library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #838