fix: remove ReDoS regexp #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
|
Thank you! |
|
Can this be backported to the 2.x series? |
TooTallNate
pushed a commit
that referenced
this pull request
Sep 22, 2017
|
@dougwilson Sure thing: https://github.com/visionmedia/debug/releases/tag/2.6.9 Curious what's holding you back from upgrading though 😅 |
platinumazure
added a commit
to eslint/eslint
that referenced
this pull request
Dec 18, 2017
This version of debug addresses a minor ReDoS issue. See debug-js/debug#501, debug-js/debug#504 for more information. Looking at the rest of the changelog, this should be a pretty low-risk upgrade.
aladdin-add
pushed a commit
to eslint/eslint
that referenced
this pull request
Dec 19, 2017
This version of debug addresses a minor ReDoS issue. See debug-js/debug#501, debug-js/debug#504 for more information. Looking at the rest of the changelog, this should be a pretty low-risk upgrade.
sodawy
added a commit
to sodawy/session
that referenced
this pull request
Jan 6, 2018
stenalpjolly
added a commit
to stenalpjolly/express
that referenced
this pull request
Aug 30, 2018
With reference to fix: remove ReDoS regexp(debug-js/debug#504)
This was referenced Dec 17, 2018
This was referenced Jan 15, 2019
This was referenced Jan 31, 2019
This was referenced Feb 1, 2019
This was referenced Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think this is the same as the original RegExp, correct me if wrong.
fix #501