Skip to content

docs: add verbose instructions for Solr 7 and Drupal 7, fixes #44 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: add verbose instructions for Solr 7 and Drupal 7, fixes #44 #45

wants to merge 3 commits into from

Conversation

jenlampton
Copy link

@jenlampton jenlampton commented Dec 13, 2024 •
edited by stasadev
Loading

The Issue

README only includes docs for Drupal 9+

How This PR Solves The Issue

Adds legacy instructions for Drupal 7

Manual Testing Instructions

Review https://github.com/jenlampton/ddev-drupal-solr/blob/44-drupal-docs/README.md

Automated Testing Overview

N/A

Related Issue Link(s)

#44 (comment)

Release/Deployment Notes

Does this affect anything else or have ramifications for other code? Does anything have to be done on deployment?

Nope :)

@jenlampton jenlampton mentioned this pull request Dec 13, 2024
Closed
@rfay rfay changed the title Added verbose instructions for Solr 7 and Drupal 7 Added verbose instructions for Solr 7 and Drupal 7, fixes #44 Dec 13, 2024
rfay
rfay requested changes Dec 24, 2024
View reviewed changes
Copy link
Member

@rfay rfay left a comment •
edited by stasadev
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for developing your expertise on this and contributing it back. I'm sorry I'm slow to respond, was hoping for another review, but this will be super helpful to people with just a little adjustment, mostly using docker-compose.solr_extra.yaml instead of editing the original file.

README.md
3. Add the schema needed for version 7: Defaults can be found in the Search API Solr in the `search_api_solr/solr-conf/7.x` directory . Copy these files into `.ddev/solr/conf`.
4. Restart Ddev: `ddev restart`.
5. Confirm Solr is working by visiting `http://<projectname>.ddev.site:8983/solr/`.
6. If the Ddev drush version is too new for Drupal 7, you may need to symlink `drush` to the `drush8` provided with Ddev. You can do this by adding a `post-start` hook inside your `.ddev/config.yaml` file as follows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand this. If a project is configured with project type drupal7 (or backdrop I think) then drush is already drush8, so why would one need to do this? Using project type php ?

@rfay
Copy link
Member

rfay commented Feb 11, 2025

I'd like to get this in, so would love it if you could return to this @jenlampton , thanks!

@stasadev stasadev changed the title Added verbose instructions for Solr 7 and Drupal 7, fixes #44 docs: add verbose instructions for Solr 7 and Drupal 7, fixes #44 Apr 24, 2025
@stasadev
Copy link
Member

Rebased.

@stasadev
Copy link
Member

this will be super helpful to people with just a little adjustment, mostly using docker-compose.solr_extra.yaml instead of editing the original file.

@jenlampton, README.md already has some mentions for docker-compose.solr_extra.yaml, so it should be easier to refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rfay rfay rfay requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jenlampton @rfay @stasadev