Skip to content

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Aug 27, 2025

Changes

This PR marks a few tests as flaky to allow other PRs to be merged. These changes will be reverted before the next release.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework
  • has entry in NEXT_CHANGELOG.md file

@rauchy rauchy requested a review from hectorcast-db August 27, 2025 12:14
@rauchy rauchy requested review from a team as code owners August 27, 2025 12:14
@rauchy rauchy temporarily deployed to test-trigger-is August 27, 2025 12:14 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4979
  • Commit SHA: dbcb9d5c59c252306ce02ca4d33634840afe154b

Checks will be approved automatically on success.

@rauchy rauchy temporarily deployed to test-trigger-is August 27, 2025 12:15 — with GitHub Actions Inactive
@@ -27,3 +27,4 @@
### Internal Changes

* Replaced `common.APIErrorBody` with corresponding structs in Go SDK ([#4936](https://github.com/databricks/terraform-provider-databricks/pull/4936))
* Mark `TestUcAccCreateShare`, `TestUcAccUpdateShare`, `TestUcAccDataSourceShares` and `TestUcAccUpdateShareReorderObject` as flaky tests ([#4979](https://github.com/databricks/terraform-provider-databricks/pull/4979)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be skipped from the changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you bypass the changelog check?

Copy link
Contributor

@hectorcast-db hectorcast-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit.

@alexott
Copy link
Contributor

alexott commented Aug 27, 2025

@rauchy you need to put NO_CHANGELOG=true into PR description

@rauchy
Copy link
Contributor Author

rauchy commented Aug 28, 2025

Closing due to a better solution in #4981.

@rauchy rauchy closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants