[Fix] Fixed syncing of effective fields in plugin framework implementation of share resource #4969
Conversation
tanmay-db
requested review from
renaudhartert-db
and removed request for
a team
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
changed the title
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
requested review from
mgyucht,
rauchy,
renaudhartert-db and
hectorcast-db
| for j := range planObjects { | ||
| if stateObjects[i].Name == planObjects[j].Name { | ||
| mode.objectLevel(ctx, &stateObjects[i], planObjects[j]) | ||
| finalObjects = append(finalObjects, stateObjects[i]) |
There was a problem hiding this comment.
what happens if the plan as an object which is not in the state? It seems that we are ignoring it.
There was a problem hiding this comment.
Yes, we ignore it because in terraform we want to create the infra from the config
There was a problem hiding this comment.
Can you explain a bit more what is what? I think I am mixing what stateObjects, planObjects and finalObjects are.
As it is, it feels that we are storing (state) a different set of objects that we are creating (plan).
| @@ -446,8 +446,13 @@ func (r *ShareResource) syncEffectiveFields(ctx context.Context, plan, state Sha | |||
| stateObjects, _ := state.GetObjects(ctx) | |||
There was a problem hiding this comment.
Are we suppressing the error? Can this fail?
rauchy
force-pushed
the
panic-share-pluginfw
branch
from
006c174 to
881c81c
Compare
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Changes
Planned objects can be less than the state objects. This can happen when someone removes an object in share resource outside the terraform (for example through UI). The changes fixes the syncing of effective fields by making sure we iterate over the planned and state objects properly.
Ref: #4913
Tests
Unit tests