Support for enforcing embedded schema #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprakash-db
requested review from
andrefurlan-db,
benc-db,
jackyhu-db,
rcypher-databricks and
yunbodeng-db
as code owners
gopalldb
approved these changes
Feb 17, 2025
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
jackyhu-db
reviewed
Feb 18, 2025
src/databricks/sql/client.py
Outdated
| self, | ||
| operation: str, | ||
| parameters: Optional[TParameterCollection] = None, | ||
| enforceEmbeddedSchema=False, |
Collaborator
There was a problem hiding this comment.
can you rename it to enforce_embedded_schema_correctness to be consistent with the meaning of the thrift API. "enforce schema" is different with "enforce schema with correctness". And please use snake case which is python style.
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
jackyhu-db
approved these changes
Feb 18, 2025
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a part of query optimization Databricks returns cached results when the underlying query is the same. This creates issue when the same query is used but with a different alias, in this case the result is the same but the metadata is different. But Databricks returns the same metadata as a part of query optimisation
Added
Added option to enforce schema to make sure the metadata is in updated state