Skip to content

Conversation

@susodapop
Copy link
Contributor

@susodapop susodapop commented Jun 29, 2022

Description

  • Adds the e2e test suite
  • Updates CONTRIBUTING with invocation instructions
  • Updates the github action for unit tests for clarity

This requires the following repository secrets will be configured on GH:

E2E_TEST_HOST
E2E_TEST_HTTP_PATH
E2E_TEST_TOKEN
on: [push]
jobs:
run-tests:
run-unit-tests:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does unit test mean in this context?

Is this mock unit test without the need for databricks account?
or is it integration test e2e which require databricks account

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit means no databricks account is required.
e2e means databricks account is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updating the CONTRIBUTING doc with this info.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Jesse.

This reverts commit f7da497.

Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
@susodapop susodapop merged commit 161b94e into main Jul 15, 2022
@susodapop susodapop deleted the add-e2e-tests branch July 15, 2022 19:30
moderakh pushed a commit to moderakh/databricks-sql-python that referenced this pull request Aug 24, 2022
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Moe Derakhshani <[email protected]>
saishreeeee pushed a commit that referenced this pull request Jun 4, 2025
Signed-off-by: Jesse Whitehouse <[email protected]>
saishreeeee pushed a commit that referenced this pull request Jun 4, 2025
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants