Rewrite inject_dartpad and expose some functionality in library #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
web/inject_dartpad.dart
was just written as a script for dart.dev and docs.flutter.dev, but the logic wasn't really reusable in other contexts and didn't have much error handling. This PR rewrites and moves the core logic into a new library and class atlib/inject_dartpad.dart
that other clients can take advantage of through using this package as a git dependency.Besides being a public library, the new library also makes a few improvements over the original script.
jsify
with directly constructing the appropriate JS object.The script in
web/inject_dartpad.dart
was then updated to use the new library, with a few additional improvements:\cc @craiglabenz Since I can't assign you as a reviewer. I guess you don't have write access to this repo.