command pub check-resolution-up-to-date
#4655
Open
+411
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @DanTup |
|
Neat, thank you! :-) What's the behaviour for this in a Pub Workspace - is the check for the overall workspace, or just the package in which it's invoked for? |
|
The check is for the overall workspace resolution, in a workspace everything is always resolved together. I'll add a test demonstrating this. |
Perfect, thank you! |
sigurdm
changed the title
pub getpub check-resolution-up-to-date
|
@szakarias suggested we make this a hidden command instead. |
szakarias
reviewed
Aug 31, 2025
| /// If any of the timestamps are out of order, the resolution in | ||
| /// pubspec.lock is validated against constraints of all pubspec.yamls, and | ||
| /// the packages of `.dart_tool/package_config.json` is validated against | ||
| /// pubspec.lock. We do this extra round of checking to accomodate for cases |
There was a problem hiding this comment.
Suggested change
| /// pubspec.lock. We do this extra round of checking to accomodate for cases | |
| /// pubspec.lock. We do this extra round of checking to accommodate for cases |
| }) async { | ||
| /// If any of the timestamps are out of order, the resolution in | ||
| /// pubspec.lock is validated against constraints of all pubspec.yamls, and | ||
| /// the packages of `.dart_tool/package_config.json` is validated against |
There was a problem hiding this comment.
Suggested change
| /// the packages of `.dart_tool/package_config.json` is validated against | |
| /// the packages of `.dart_tool/package_config.json` are validated against |
| /// work as possible. Specifically we avoid parsing any yaml when the | ||
| /// timestamps are in the right order. | ||
| /// | ||
| /// `.dart_tool/package_config.json` is read parsed. In the case of `dart |
There was a problem hiding this comment.
Suggested change
| /// `.dart_tool/package_config.json` is read parsed. In the case of `dart | |
| /// `.dart_tool/package_config.json` is read and parsed. In the case of `dart |
| /// | ||
| /// `.dart_tool/package_config.json` is read parsed. In the case of `dart | ||
| /// run` this is acceptable: we speculate that it brings it to the file | ||
| /// system cache and the dart VM is going to read the file anyways. |
There was a problem hiding this comment.
Suggested change
| /// system cache and the dart VM is going to read the file anyways. | |
| /// system cache and the dart VM is going to read the file anyway. |
szakarias
approved these changes
Aug 31, 2025
| @@ -0,0 +1,107 @@ | |||
| // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file | |||
There was a problem hiding this comment.
Suggested change
| // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file | |
| // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file |
| return false; | ||
| } | ||
| return true; | ||
| /// Whether or not the `.dart_tool/package_config.json` file is was |
There was a problem hiding this comment.
Suggested change
| /// Whether or not the `.dart_tool/package_config.json` file is was | |
| /// Whether or not the `.dart_tool/package_config.json` file was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same heuristic check that
dart runuses to ensure that the resolution is usable.Attempt to fix #1447
The command is hidden for now, we are unsure how we want to recommend end-users use it. But it will be available for vscode and others to use.