Skip to content

Conversation

@scheglov
Copy link
Contributor

I plan to make this formal parameter required.

Although it is sad that internal AnalysisContextCollectionImpl is used.

@scheglov scheglov force-pushed the AnalysisContextCollectionImpl-withFineDependencies-true branch from 7a3814f to 04eece4 Compare November 15, 2025 20:12
@sigurdm sigurdm requested a review from szakarias November 17, 2025 09:18
@sigurdm
Copy link
Contributor

sigurdm commented Nov 17, 2025

Although it is sad that internal AnalysisContextCollectionImpl is used.

I agree. I don't have the full context, but I wonder if we could get away with not using it?

@srawlins
Copy link
Member

I don't have the full context, but I wonder if we could get away with not using it?

I don't know if this is the only reason, but one reason is setting those ..warning = false..lint = false values; at the time they were added, they saved 5% time to generate docs, which I felt was valuable.

I'd like to remove that setting, see dart-lang/sdk#61520, in favor of a more "process-wide" or "Analysis context collection-wide" setting to say, "when I ask to resolve code, please, no need to check lint rules, or warning rules, or even errors, and no need to enter function bodies. Just give me the resolved ASTs and element model."

@szakarias szakarias merged commit 3f1f09c into dart-lang:main Nov 18, 2025
13 checks passed
@sigurdm
Copy link
Contributor

sigurdm commented Nov 18, 2025

I wonder if those settings could be exposed in the public api? They sound generally useful...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants