Skip to content

Conversation

@mvarendorff
Copy link
Contributor

The sidebar currently links to #extension

<li class="section-title"><a href="{{{href}}}#extension">Extensions</a></li>

While the matching id is extensions:

<section class="summary offset-anchor" id="extensions">

This PR matches the link in the sidebar to the ID in the library page.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jul 13, 2021
@devoncarew
Copy link
Contributor

Thanks for the PR! Will add @srawlins for review.

@devoncarew devoncarew requested a review from srawlins July 13, 2021 15:01
@jcollins-g jcollins-g self-requested a review August 6, 2021 21:13

{{#hasPublicExtensions}}
<li class="section-title"><a href="{{{href}}}#extension">Extensions</a></li>
<li class="section-title"><a href="{{{href}}}#extensions">Extensions</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @geisterfurz007! Rebuilt the aot renderer using grind build so this can land.

@jcollins-g jcollins-g merged commit be86d03 into dart-lang:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Google CLA check succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants