Cache the current working directory #2641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
May 11, 2021
| Folder __directoryCurrent; | ||
| Folder get _directoryCurrent => | ||
| resourceProvider.getFolder(resourceProvider.pathContext.current); | ||
| __directoryCurrent ??= resourceProvider.getFolder(_directoryCurrentPath); |
Member
There was a problem hiding this comment.
LOL I am pretty sure I've considered this optimization and dismissed it thinking I dunno what this crazy package does 😆
Also, just to be sure; bizarro stuff like @tool shouldn't affect this, right?
Contributor
Author
There was a problem hiding this comment.
I think I just assumed every time I implemented one of these layers of abstraction that some other layer was caching it. Apparently not :-D. Tools might change the working directory in a subprocess, but we're fine for the parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Claw back the performance lost since 0.42.0 with this one simple trick!
Reduces the 6% performance lost since 0.42.0 documenting flutter to ~.5% (almost within margin of error).