Skip to content

Fix test passing issues #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2020
Merged

Fix test passing issues #2424

merged 4 commits into from
Nov 16, 2020

Conversation

@jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Nov 13, 2020 •
edited
Loading

Fixes #2422 and #2423.

Also corrects an issue where we were relying on a default in the globber inappropriately.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Nov 13, 2020
@coveralls
Copy link

coveralls commented Nov 13, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 91.398% when pulling 504186a on fix-test-passing-issues into 85ae869 on master.

@jcollins-g jcollins-g marked this pull request as ready for review November 13, 2020 20:26
@jcollins-g jcollins-g requested a review from srawlins November 13, 2020 20:26
srawlins
srawlins approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the tests

@jcollins-g jcollins-g merged commit c4bd753 into master Nov 16, 2020
@jcollins-g jcollins-g deleted the fix-test-passing-issues branch August 11, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srawlins srawlins srawlins approved these changes

Assignees

No one assigned

Labels

cla: yes Google CLA check succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2.12.0-31.0.dev causes dartdoc tests to always pass even when broken

3 participants

@jcollins-g @coveralls @srawlins