Skip to content

Privatize some of the interface of Canonicalization, Category #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

Privatize some of the interface of Canonicalization, Category #2291

merged 1 commit into from
Aug 11, 2020

Conversation

@srawlins
Copy link
Member

@srawlins srawlins commented Aug 11, 2020

  • Deprecate the public method Canonicalization.scoreElementWithLibrary.
  • Deprecate the public getters ScoredCandidate.reasons and ScoredCandidate.element, method ScoredCandidate.alterScore.
  • Deprecate the setters Category.package, and Category.config, and the public method Category.fileType.
  • Deprecate the unused methods Category.linkedName and Category.categoryLabel.

These should be removed on a major release number, like 1.0.0.

@srawlins srawlins requested a review from scheglov August 11, 2020 05:32
@googlebot googlebot added the cla: yes Google CLA check succeeded. label Aug 11, 2020
@srawlins
Copy link
Member Author

srawlins commented Aug 11, 2020

Side-stepping the flutter bot timeout; happening on all PRs.

@srawlins srawlins merged commit 4410c77 into dart-lang:master Aug 11, 2020
@srawlins srawlins deleted the privatize-1 branch August 11, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scheglov scheglov scheglov approved these changes

Assignees

No one assigned

Labels

cla: yes Google CLA check succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srawlins @scheglov @googlebot