Skip to content

Allow injected HTML in a macro which is output by a tool #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2020
Merged

Allow injected HTML in a macro which is output by a tool #2274

merged 3 commits into from
Jul 24, 2020

Conversation

@srawlins
Copy link
Member

@srawlins srawlins commented Jul 24, 2020

Fixes #1945

  • Move ~600 lines of comment-directive processing out of model_element.dart into a new mixin.
  • Extract all RegExp into top-level or static variables.
  • Process comment directives after replacing a macro
  • change ModelElement.canOverride to a private getter.
  • dartfmt testing/test_package/lib/example.dart

@srawlins srawlins requested a review from scheglov July 24, 2020 14:30
@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jul 24, 2020
@srawlins srawlins merged commit 6d5396c into dart-lang:master Jul 24, 2020
@srawlins srawlins deleted the tool-macro-html branch July 24, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scheglov scheglov scheglov approved these changes

Assignees

No one assigned

Labels

cla: yes Google CLA check succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Macros don't expand dartdoc directives injected by tools

3 participants

@srawlins @scheglov @googlebot