Skip to content

Fix exception and simplify inheritance #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020
Merged

Fix exception and simplify inheritance #2214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/src/model/method.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/source/line_info.dart';
import 'package:analyzer/src/dart/element/member.dart' show Member;
import 'package:dartdoc/src/element_type.dart';
import 'package:dartdoc/src/model/model.dart';

class Method extends ModelElement
Expand Down Expand Up @@ -95,9 +94,6 @@ class Method extends ModelElement

String get linkedReturnType => modelType.createLinkedReturnTypeName();

@override
DefinedElementType get modelType => super.modelType;

@override
Method get overriddenElement {
if (_enclosingContainer is Extension) {
Expand Down
5 changes: 1 addition & 4 deletions lib/src/model/type_parameter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class TypeParameter extends ModelElement {
TypeParameterElement get _typeParameter => element as TypeParameterElement;
}

abstract class TypeParameters implements ModelElement {
mixin TypeParameters implements ModelElement {
String get nameWithGenerics => '$name$genericParameters';

String get nameWithLinkedGenerics => '$name$linkedGenericParameters';
Expand All @@ -82,9 +82,6 @@ abstract class TypeParameters implements ModelElement {
String get linkedGenericParameters =>
_typeParametersRenderer.renderLinkedGenericParameters(this);

@override
DefinedElementType get modelType;

List<TypeParameter> get typeParameters;

TypeParametersRenderer get _typeParametersRenderer =>
Expand Down