Remove driver and session from PackageGraph #2204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
May 8, 2020
Contributor
jcollins-g
left a comment
jcollins-g
left a comment
There was a problem hiding this comment.
LGTM
This is going in the general direction dartdoc has been moving for a while. Originally, all elements were lazily fetched and the fact we still have some support for that is vestigal at this point. Thanks for the cleanup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I would like to remove the presence of
AnalysisDriverand Session fromPackageGraph.Why
PackageGraphis available to many model objects and it makes good sense to reduce the available API surface.It is preferred that
PackageBuilderpopulates all necessary information for dartdoc to function during build phase rather than relying on model objects to lazily get them fromAnalysisSession. This allows us to handle situations where anAnalysisSessionis not available such as constructing ResolvedLibrary objects from summary data.