Skip to content

Fix the search widget on non-root pages #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

Fix the search widget on non-root pages #2125

merged 1 commit into from
Jan 10, 2020

Conversation

@jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Jan 10, 2020

Fixes #2124
Also simplifies the fix for #2117

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jan 10, 2020
@jdkoren jdkoren requested a review from jcollins-g January 10, 2020 17:51
@jdkoren
Copy link
Contributor Author

jdkoren commented Jan 10, 2020

I wonder if we need the same change here

@jdkoren jdkoren merged commit 3169171 into dart-lang:master Jan 10, 2020
@isoos isoos mentioned this pull request Feb 19, 2020
Closed
@jcollins-g jcollins-g mentioned this pull request Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jcollins-g jcollins-g jcollins-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Google CLA check succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clicking search result while on non-root page goes to page not found

3 participants

@jdkoren @jcollins-g @googlebot