Skip to content

Replace getBasestElement() with Element.declaration #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2020
Merged

Replace getBasestElement() with Element.declaration #2106

merged 1 commit into from
Jan 2, 2020

Conversation

@scheglov
Copy link
Contributor

@scheglov scheglov commented Dec 25, 2019

dart-lang/sdk#29600 was fixed by adding Element.declaration and verifying that Member is never created around another Member.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 25, 2019
@scheglov scheglov requested a review from jcollins-g December 26, 2019 21:01
@scheglov scheglov merged commit 88ba99b into dart-lang:master Jan 2, 2020
@scheglov scheglov deleted the replace-getBasestElement-with-declaration branch January 2, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jcollins-g jcollins-g jcollins-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Google CLA check succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scheglov @jcollins-g @googlebot