Skip to content

Remove the unneeded ModelFunctionAnonymous and related code #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2019
Merged

Remove the unneeded ModelFunctionAnonymous and related code #2084

merged 2 commits into from
Dec 3, 2019

Conversation

@jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Dec 2, 2019

Implements a TODO from @scheglov to strip code that can no longer be reached on modern versions of the analyzer.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Dec 2, 2019
@coveralls
Copy link

coveralls commented Dec 2, 2019

Coverage Status

Coverage increased (+0.5%) to 94.012% when pulling d0d2466 on cleanup-anonymous into 0a0135a on master.

@jcollins-g jcollins-g merged commit f8d33bc into master Dec 3, 2019
@jcollins-g jcollins-g deleted the cleanup-anonymous branch December 3, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scheglov scheglov scheglov approved these changes

@bwilkerson bwilkerson Awaiting requested review from bwilkerson

Assignees

No one assigned

Labels

cla: yes Google CLA check succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jcollins-g @coveralls @scheglov @googlebot