Skip to content

Conversation

devoncarew
Copy link
Member

  • update to the latest lint set versions
  • update to the latest sdk versions (so we'll pull in the most recent lint sets)
  • try and minimize formatting diffs via trailing_commas: preserve

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Jun 2, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ⚠️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/samples/lib/brick_breaker.dart

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

This check can be disabled by tagging the PR with skip-license-check.

@@ -22,3 +22,6 @@ linter:
- prefer_final_in_for_each
- prefer_final_locals
- sort_pub_dependencies

formatter:
trailing_commas: preserve
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to override the default formatter behavior?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to minimize diff here but don't really know that this is helping. I can revert this and re-format to see.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are already using the latest formatter with the defaults, so this is probably adding some extra noise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted! Still a fair number of formatting diffs. I think the trailing_commas: preserve option would only help here if there was some local formatting that we were trying to preserve.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're saving some LOC with the new formatter 🙌

@devoncarew devoncarew merged commit 28f79a7 into main Jun 2, 2025
21 checks passed
@devoncarew devoncarew deleted the update_analysis_options branch June 2, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants