Skip to content

Conversation

@dterrahe
Copy link
Member

@dterrahe dterrahe commented Feb 2, 2025

fixes #18196

This does two things:

  • by default, it no longer switches to the "C" locale while compiling opencl. However this can be reenabled by adding "opencl_force_c_locale" to darktablerc
  • even when the override is in place, it switches to "C" in far fewer cases and shorter, namely only when actually compiling. So if the workaround is still needed, it would only impact the first startup after program or driver updates and maybe not even break anything there.

I have not tested this beyond that it compiles and runs, because I cannot easily replicate the original issue to verify this fixes it.

RELEASE NOTE:

  • A workaround for old broken AMD opencl drivers that has been in place for 12 years has been disabled by default. Hopefully more recent drivers don't need it anymore and it caused problems with the translation of the user interface during startup, causing part of it to appear in English.
    If you have problems with OpenCL that you believe may be caused by this change, please do two things:
    1. Add the line opencl_force_c_locale=anything to your ~/.config/darktable/darktablerc file.
    2. If that solves your problem, please report the issue to github PR #xxxx, including information on the make of your GPU and the version of your drivers. We can then for the next release either by default reenable the workaround for drivers that need them, or warn people with antiquated drivers that they need to update.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me, we can also later only do that if AMD is in the list of OpenCL driver.

@TurboGit TurboGit added this to the 5.2 milestone Feb 2, 2025
@TurboGit TurboGit added the scope: translation / strings make darktable international label Feb 2, 2025
@TurboGit TurboGit merged commit 92d8128 into darktable-org:master Feb 2, 2025
6 checks passed
@rgr59
Copy link

rgr59 commented Feb 2, 2025

Tested this PR and cannot reproduce #18196 anymore. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: translation / strings make darktable international

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sometimes darktable GUI is not fully localized after startup

3 participants