-
Notifications
You must be signed in to change notification settings - Fork 138
initial asyncio implementation after durable task asyncio work #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
filintod
wants to merge
6
commits into
dapr:main
Choose a base branch
from
filintod:filinto/asyncio
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,938
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filintod
commented
Aug 20, 2025
3 tasks
sicoyle
reviewed
Nov 18, 2025
ext/dapr-ext-workflow/dapr/ext/workflow/workflow_activity_context.py
Outdated
Show resolved
Hide resolved
| These examples mirror `examples/workflow/` but author orchestrators with `async def` using the | ||
| async workflow APIs. Activities remain regular functions unless noted. | ||
|
|
||
| How to run: |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add a venv reference in here too
sicoyle
reviewed
Nov 18, 2025
examples/workflow/requirements.txt
Outdated
Comment on lines
1
to
11
| # dapr-ext-workflow-dev>=1.15.0.dev | ||
| # dapr-dev>=1.15.0.dev | ||
|
|
||
| # local development: install local packages in editable mode | ||
|
|
||
| # if using dev version of durabletask-python | ||
| -e ../../../durabletask-python | ||
|
|
||
| # if using dev version of dapr-ext-workflow | ||
| -e ../../ext/dapr-ext-workflow | ||
| -e ../.. |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| # dapr-ext-workflow-dev>=1.15.0.dev | |
| # dapr-dev>=1.15.0.dev | |
| # local development: install local packages in editable mode | |
| # if using dev version of durabletask-python | |
| -e ../../../durabletask-python | |
| # if using dev version of dapr-ext-workflow | |
| -e ../../ext/dapr-ext-workflow | |
| -e ../.. | |
| dapr-ext-workflow-dev>=1.15.0.dev | |
| dapr-dev>=1.15.0.dev | |
| # local development: install local packages in editable mode | |
| # if using dev version of durabletask-python | |
| # -e ../../../durabletask-python | |
| # if using dev version of dapr-ext-workflow | |
| # -e ../../ext/dapr-ext-workflow | |
| # -e ../.. |
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md
Outdated
Show resolved
Hide resolved
sicoyle
reviewed
Nov 18, 2025
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/Dapr-Workflow-Middleware-Outbound-Hooks.md
Outdated
Show resolved
Hide resolved
d42eb41 to
469c2e4
Compare
Signed-off-by: Filinto Duran <[email protected]>
469c2e4 to
12269e7
Compare
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it possible to use python workflow that manages code using asyncio to retrofit code that is already written as async/await.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: