Include packages for x86/x64 onigwrap.dll, and dynamic binding betwee… #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for the contribution. Please take a look to the PR review comments. |
|
@Andrew1Medvedev did you manage to take a look at the comments? Thanks 🙏 |
|
I did not find any PR review comments. Could you please send me on my e-mail: |
danipen
requested changes
Jul 3, 2023
build/TextMateSharp.targets
Outdated
| @@ -0,0 +1,3 @@ | |||
| <Project> | |||
| <Import Project="$(MSBuildThisFileDirectory)\CopyNativeLibraries.targets" /> | |||
There was a problem hiding this comment.
I think is clearer to remove this file and reference directly CopyNativeLibraries.target from the TexmateSharp.csproj project (so it's explicit what we do).
| Include="..\..\build\CopyNativeLibraries.targets" /> | ||
| <Content Pack="True" | ||
| PackagePath="build" | ||
| Include="..\..\build\TextMateSharp.targets" /> |
There was a problem hiding this comment.
Why are we referencing both CopyNativeLibraries.tsrgets and TextmateSharp.targets here?
|
It is enough to reference only one *.targets, but it filename must be the same as the NuGet Package Id. |
danipen
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n them #51