Skip to content

Conversation

@haslingerm
Copy link
Contributor

  • Added grammar definition for asciidoc based on work by Matt Neuburg
    • Author expressed permission to use his work under MIT license with attribution in a GitHub issue despite not providing a license file
  • Solution compiles, tests are green
  • Ran TextMateSharp.Demo against a sample .adoc file
    • No exceptions, looks good
    • Some defects for complex documents, but overall ok (grammar is pretty complex, would require considerable work to get a better result)
  • Configuration files (cgmanifest.json, package.json, package.nls.json) added on a best-effort basis

If I missed a configuration, can fix an error or improve the PR somehow please let me know.

@danipen
Copy link
Owner

danipen commented Nov 18, 2022

Test failed. I think the fix is trivial.

@haslingerm
Copy link
Contributor Author

Yeah, missed the second tests project, sorry, on it

@danipen danipen merged commit f95331c into danipen:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants