Skip to content

Conversation

danielgtaylor
Copy link
Owner

@danielgtaylor danielgtaylor commented Jan 12, 2023

This PR:

  • Adds a where clause for maps
  • Adds a .length for maps to get the number of pairs (removed due to ambiguity)
  • Updates convenience functions to take any instead of map[string]any
  • Provides better error messages

@codecov-commenter
Copy link

Codecov Report

Base: 73.09% // Head: 74.76% // Increases project coverage by +1.66% 🎉

Coverage data is based on head (20718b9) compared to base (194704c).
Patch coverage: 89.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   73.09%   74.76%   +1.66%     
==========================================
  Files           7        7              
  Lines        1022     1046      +24     
==========================================
+ Hits          747      782      +35     
+ Misses        212      203       -9     
+ Partials       63       61       -2     
Impacted Files Coverage Δ
typecheck.go 78.73% <80.00%> (+6.51%) ⬆️
expr.go 100.00% <100.00%> (ø)
interpreter.go 73.35% <100.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielgtaylor danielgtaylor changed the title feat: where and .length for maps; various small fixes feat: where for maps; various small fixes Jan 12, 2023
@danielgtaylor danielgtaylor merged commit e8452fc into main Jan 12, 2023
@danielgtaylor danielgtaylor deleted the map-where branch January 12, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants