Add Integration tests in Python #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telday
force-pushed
the
integration-tests
branch
4 times, most recently
from
ad81174 to
15774ab
Compare
6 tasks
telday
force-pushed
the
integration-tests
branch
4 times, most recently
from
393c871 to
8d21476
Compare
telday
force-pushed
the
integration-tests
branch
from
8d21476 to
ca19dbd
Compare
telday
changed the title
| """ | ||
| resp = self.api.show_public_keys(self.account, 'Variable', 'one/password') | ||
|
|
||
| self.assertIsInstance(resp, str) |
There was a problem hiding this comment.
Not necessarily breaking, but wondering if this assertion actually confirms that the API call worked. Seems a bit too general compared to a lot of the other test cases.
There was a problem hiding this comment.
This test is definitely lighter then others. However I check that the return type is a string because this endpoint is supposed to return a plain text body so I am just making sure that the client returns the proper type. These are just integration tests so I didn't want to add any checks that were too complicated in.
|
Also a rebase, PRs that were open before the GH Action was merged won't be caught. |
telday
force-pushed
the
integration-tests
branch
from
ca19dbd to
0695f1e
Compare
Also added an api_config file which will get a default configuration for tests. Should reduce levels of code duplication in the tests
Auto-generated import statements in the test files were causing these messages. Removed them because we cannot change this
Reduces code duplication for the setUpClass and tearDownClass methods
telday
force-pushed
the
integration-tests
branch
from
0695f1e to
628b82a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.