Skip to content

Conversation

@john-odonnell
Copy link
Contributor

@john-odonnell john-odonnell commented Apr 19, 2021

What does this PR do?

  • bin/integration_tests and bin/test_enterprise are combined into bin/test_integration
  • updates integration test workflow to use new script
  • bin/generate_client output directory bug fix, and now requires language argument
  • bin/api_test -> bin/test_api_contract
  • bin/start -> bin/dev
  • small fix to malformed function call in C# tests
  • small updates to CONTRIBUTING.md. More documentation updates are saved for Update CONTRIBUTING to have a more clear intro to project scripts #164

What ticket does this PR close?

Resolves #166

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@john-odonnell john-odonnell force-pushed the rework-utility-scripts branch from 3ce624a to fc9aa92 Compare April 19, 2021 17:33
@john-odonnell john-odonnell force-pushed the rework-utility-scripts branch 14 times, most recently from cecb3bb to 0d8a7b6 Compare April 30, 2021 15:08
@john-odonnell john-odonnell marked this pull request as ready for review April 30, 2021 15:26
@john-odonnell john-odonnell requested a review from a team as a code owner April 30, 2021 15:26
@john-odonnell john-odonnell force-pushed the rework-utility-scripts branch from 0d8a7b6 to 7cd715f Compare April 30, 2021 15:36
Copy link
Contributor

@telday telday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overal. A few small comments

announce "CONJUR OPENAPI DESCRIPTION :: INTEGRATION TESTS"
cat << EOF
DESCRIPTION
This script tests a Conjur client generated from the OpenAPI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this addition, definitely makes the formatting much nicer!

@john-odonnell john-odonnell force-pushed the rework-utility-scripts branch from 7cd715f to a2331fc Compare April 30, 2021 23:03
@john-odonnell john-odonnell force-pushed the rework-utility-scripts branch from a2331fc to c91c02e Compare May 10, 2021 14:14
@john-odonnell john-odonnell requested a review from telday May 11, 2021 17:23
telday
telday previously approved these changes May 11, 2021
Copy link
Contributor

@telday telday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Functions include checking the status of enterprise
deployment and stopping OSS/Enterprise environments.
Combines bin/integration_tests and bin/test_enterprise
into bin/test_integration, which runs OSS tests by
default.
Fixes bug where the old client was never removed due
to the change to output dir location from out/<lang>
to out/<appliance>/<lang>. Updates script to require
a language argument.
@john-odonnell
Copy link
Contributor Author

@telday needed to rebase. Could you hit me with another approval?

@john-odonnell john-odonnell merged commit c0201cd into main May 14, 2021
@john-odonnell john-odonnell deleted the rework-utility-scripts branch May 14, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework integration tests script

3 participants