- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3
Rework utility scripts #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3ce624a    to
    fc9aa92      
    Compare
  
    cecb3bb    to
    0d8a7b6      
    Compare
  
    0d8a7b6    to
    7cd715f      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overal. A few small comments
| announce "CONJUR OPENAPI DESCRIPTION :: INTEGRATION TESTS" | ||
| cat << EOF | ||
| DESCRIPTION | ||
| This script tests a Conjur client generated from the OpenAPI | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this addition, definitely makes the formatting much nicer!
7cd715f    to
    a2331fc      
    Compare
  
    a2331fc    to
    c91c02e      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Functions include checking the status of enterprise deployment and stopping OSS/Enterprise environments.
Combines bin/integration_tests and bin/test_enterprise into bin/test_integration, which runs OSS tests by default.
Fixes bug where the old client was never removed due to the change to output dir location from out/<lang> to out/<appliance>/<lang>. Updates script to require a language argument.
c91c02e    to
    8a040c2      
    Compare
  
    | @telday needed to rebase. Could you hit me with another approval? | 
What does this PR do?
bin/integration_testsandbin/test_enterpriseare combined intobin/test_integrationbin/generate_clientoutput directory bug fix, and now requires language argumentbin/api_test->bin/test_api_contractbin/start->bin/devCONTRIBUTING.md. More documentation updates are saved for Update CONTRIBUTING to have a more clear intro to project scripts #164What ticket does this PR close?
Resolves #166
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or