Skip to content

Conversation

@telday
Copy link
Contributor

@telday telday commented Apr 15, 2021

What does this PR do?

Added naming configuration and a template/integration tests to ensure that authentication works.

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@telday telday requested a review from a team as a code owner April 15, 2021 16:29
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@telday telday merged commit 62a6f67 into main Apr 16, 2021
@telday telday deleted the java-client branch April 16, 2021 14:43
@telday telday restored the java-client branch April 16, 2021 14:43
@telday telday deleted the java-client branch April 16, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants