Skip to content

Conversation

@telday
Copy link
Contributor

@telday telday commented Feb 23, 2021

What does this PR do?

Added an initial C#/.NET client to the project along with some basic tests to ensure it can properly authenticate with Conjur.

What ticket does this PR close?

Resolves #94

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@telday telday force-pushed the dot-net-client branch 2 times, most recently from d6f2478 to 8183e8a Compare February 25, 2021 14:21
@telday telday marked this pull request as ready for review February 25, 2021 14:28
@telday telday requested a review from a team as a code owner February 25, 2021 14:28
@telday telday force-pushed the dot-net-client branch 3 times, most recently from 235dc94 to 8640aff Compare February 26, 2021 18:47
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small issue with running both tests in one bin/integration_tests call

@@ -0,0 +1,724 @@
{{>partial_header}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which parts of these templates did you have to edit? Just for my own curiosity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One was to update how enums were converted to strings and the other was to update how the body of the requests was rendered

Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@telday telday merged commit dd70068 into main Mar 1, 2021
@telday telday deleted the dot-net-client branch April 16, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is an initial generated .Net core client

3 participants