Add Certificate Authority Endpoint #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-odonnell
force-pushed
the
add-cert-auth-endpoint
branch
5 times, most recently
from
bfdd54c to
67292c2
Compare
telday
suggested changes
Jan 19, 2021
john-odonnell
force-pushed
the
add-cert-auth-endpoint
branch
2 times, most recently
from
b8a1578 to
3c2a347
Compare
Proves basic functionality of /ca/{account}/{service_id}/sign endpoint.
Includes Intermediate CA private keys to configure CA service.
john-odonnell
force-pushed
the
add-cert-auth-endpoint
branch
from
3c2a347 to
810d55a
Compare
After updating tests for the Conjur CA endpoint, a Roles test had to be updated. Confirming the test's results was generalized.
john-odonnell
force-pushed
the
add-cert-auth-endpoint
branch
from
c17b0b4 to
157fbc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the Certificate Authority endpoint
/ca/{account}/{service_id}/signto the OpenAPI spec,along with test confirming its behavior.
The endpoint currently does not support the
Accept: application/x-pem-fileheader, as the OpenAPI Python client generator overrides the manual header assignment.What ticket does this PR close?
Resolves #63
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or