Skip to content

Update readme with new APM requirement and extend text limit on 500error #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2025
Merged

Update readme with new APM requirement and extend text limit on 500error #312

merged 2 commits into from
Aug 31, 2025

Conversation

steinmn
Copy link
Contributor

@steinmn steinmn commented Aug 30, 2025 •
edited
Loading

Fix #309
Fix #310

sveinse
sveinse approved these changes Aug 31, 2025
View reviewed changes
Copy link
Collaborator

@sveinse sveinse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If nitpicking: Perhaps the MAX_DEBUG_TEXT_LEN name should be more specific? I could get the impression it applies to all logging and not specific to one thing. MAX_DEBUG_TEXT_LEN_ON_500? IDK. Your call.

@sveinse sveinse added this to the v0.8.3 milestone Aug 31, 2025
@steinmn
Copy link
Contributor Author

steinmn commented Aug 31, 2025

Agreed

sveinse
sveinse approved these changes Aug 31, 2025
View reviewed changes
Copy link
Collaborator

@sveinse sveinse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sveinse sveinse merged commit 1bfe59a into custom-components:master Aug 31, 2025
4 checks passed
@steinmn steinmn deleted the update-readme-w-apm-requirement branch September 1, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sveinse sveinse sveinse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.8.3

Development

Successfully merging this pull request may close these issues.

Log on 500 errors are capped too short Can't change any property of the zaptec installation, but can change all properties of the charger itself

2 participants

@steinmn @sveinse