-
Notifications
You must be signed in to change notification settings - Fork 23
Add validation and monitoring of requirement compatibility with HA #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation and monitoring of requirement compatibility with HA #307
Conversation
Also disable ruff check for dev-scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and nitpicks. Generally it looks good. I haven't done any verification of the functionality of the python file, just been looking at the code structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now. Approved.
Unless there is something you want added here last minute?
No, I think we can wrap this one up |
Resolves #305
There are 2 checks:
1 is run on every push and PR in validate.yaml, and also periodically in monitor-requirements.yaml.
2 is only run on push and PR if there are changes made to either manifest.json and/or hacs.json
Example runs: