feat: split wallet and max balance behavior in new large token inputs #1535
+262
−371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ickable or not now
0xAlunara
requested review from
0xPearce,
0xtutti,
DanielSchiavini and
OnlyJousting
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xAlunara
changed the title
0xAlunara
commented
Oct 18, 2025
0xAlunara
commented
Oct 18, 2025
The PR should be up-to-date now |
apps/main/src/loan/components/PageLoanManage/CollateralDecrease/index.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1528. This PR can be considered half a PR, because there's some other things I have yet to change in the
LargeTokenInput, but I want to keep the PR easier to review and pump something out while I'm off for a week. This component is still in beta only anyway.PS: I have been unable to test the new
inputBalanceUsdstuff, as it relies on a fix inmain, but this PR is based off a branch which is based off a branch which is based off an old main 🙂maxBalanceinLargeTokenInputintowalletBalanceandmaxBalance. The wallet ballance really is for showing whatever balance the user has currently in in his wallet, and it's clickable. Max balance has effect on both the slider and chip functionality. These values can differ. You can have 100 crvUSD in your wallet, while max borrow could be for 1337 crvUSD in case you want to borrow more.LargeTokenInputby removing thebalanceDecimalsproperty, I don't think it's no longer needed now weNumericTextFieldhandlesDecimalnumbers only.