Fix TabList's arrow flakiness in storybook #6192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b38229e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Request PR reviews on Slack
Please reach out to the design system team on Slack in
#prod_design_systemfor PR reviews. GitHub notifications (e.g. from tagging a person) are not actively monitored.We often have flaky stories which use the Tablist as the snapshot would randomly have the TabList arrow visible when it shouldn't.
From testing canary and re-run chromatic a few times, looks like requestAnimationFrame was the trick to fix it
Why
We have been having issue with the left and right arrow of TabList being flaky in chromatic snapshot (like this one) when they are visible when they shouldn't.
Tested as canary in conversations-ui after a few chromatic runs, requestAnimation seems to have fixed it
What