Skip to content

fix endless loop with empty files #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2017
Merged

fix endless loop with empty files #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,11 @@ class Comb {
let filename = options && options.filename || '';
let context = options && options.context;
let tree;
const lint = this.lint;

if (!text) return this.lint ? [] : text;
if (!text) return new Promise(function(resolve) {
resolve(lint ? [] : text);
});

if (!syntax) syntax = 'css';
this.syntax = syntax;
Expand Down
Empty file added test/core/scss/empty.scss
View file
Open in desktop
Empty file.
7 changes: 7 additions & 0 deletions test/core/scss/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,13 @@ describe('scss', function() {
return test.shouldBeEqual('content.scss');
});

it('Should parse an empty file', function() {
let test = new Test(this);
test.comb.configure({});

return test.shouldBeEqual('empty.scss');
});

it('Should parse functions', function() {
let test = new Test(this);
test.comb.configure({});
Expand Down