refactor: add more lint rules #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase by adding new lint rules to enforce a more consistent style and improve code readability. It includes updates to lint configuration in pyproject.toml, import reordering, and minor adjustments to return statements and test file imports.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added new lint rules and adjusted ignore configuration. |
| django_object_actions/init.py | Reordered imports and updated all ordering. |
| django_object_actions/utils.py | Reordered URL imports and added exception chaining in dispatch. |
| example_project/polls/admin.py | Adjusted import ordering and made an explicit return in a view method. |
| example_project/polls/migrations/0002_auto_*.py | Reordered migration imports for consistency. |
| example_project/polls/migrations/0001_initial.py | Reordered migration imports for consistency. |
| django_object_actions/tests/test_admin.py | Improved import ordering by removing duplicate imports. |
| example_project/urls.py | Reordered import lines for clarity. |
| example_project/polls/factories.py | Simplified the get_random_string implementation. |
| django_object_actions/tests/tests.py | Minor changes to import order for clarity. |
| django_object_actions/tests/test_utils.py | Adjusted import ordering in tests for consistency. |
crccheck
commented
Mar 27, 2025
| except KeyError: | ||
| raise Http404("Action does not exist") | ||
| except KeyError as exc: | ||
| raise Http404("Action does not exist") from exc |
There was a problem hiding this comment.
TIL raise from https://peps.python.org/pep-3134/
from 2005!
papajuans
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing in rules I've had success with elsewhere. More consistent style helps with readability and maintainability. Some of the rules help with code simplicity and with reducing bugs too.