Skip to content

Conversation

@eisenwave
Copy link
Member

Fixes #8244.

This synchronizes the function signature with the definition in https://eel.is/c++draft/meta.reflection.result#lib:reflect_constant

The paper author has confirmed that the CWG intent is for the parameter to be T value; the use of const T& in the synopsis is an editorial oversight.

@eisenwave eisenwave added the P1-Important Misapplication of paper, malformed code, internal inconsistencies label Nov 6, 2025
@eisenwave
Copy link
Member Author

Now looking at it, we also have at least one mismatch between the parameter names in the synopsis (value) and in the definitions (expr). That's a much less severe problem than function signature differences though.

@jensmaurer
Copy link
Member

Can you rename the function parameter in the synopsis to "expr" as well?

Otherwise, looks good.

@eisenwave eisenwave force-pushed the synchronize-reflect-constant-synopsis branch from bd56f25 to 08de7fd Compare November 6, 2025 13:23
@eisenwave eisenwave changed the title [meta.syn] Synchronize reflect_constant parameter with definition [meta.syn] Synchronize reflect_constant/reflect_object parameters with definition Nov 6, 2025
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 6, 2025

Great, thanks!

@tkoeppe tkoeppe merged commit 1e37bdb into cplusplus:main Nov 6, 2025
2 checks passed
@tkoeppe tkoeppe removed the P1-Important Misapplication of paper, malformed code, internal inconsistencies label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mismatch in reflect_constant declaration

4 participants